Map of maps page is broken

[jywarren]

We show all maps on a map, at http://mapknitter.org/map/map -- but this is currently broken. The error is:

Started GET "/map/map" for 184.179.58.42 at 2018-02-02 17:48:56 +0000
Processing by MapsController#map as HTML
  Rendered maps/map.html.erb (34.8ms)
Completed 500 Internal Server Error in 36.7ms

ActionView::Template::Error (Association named 'users' was not found on Map; perhaps you misspelled it?):
    25:       (function() {
    26:       map = L.map('map').setView([0,0], 4);
    27:       L.tileLayer("https://a.tiles.mapbox.com/v3/jywarren.map-lmrwb2em/{z}/{x}/{y}.png").addTo(map);
    28:       <% @maps.each do |map| %>
    29:         <% if map.lat && map.lon %>
    30:           L.marker([<%= map.lat %>, <%= map.lon %>]).addTo(map).bindPopup("<a href='/maps/<%= map.slug %>'><%= map.name.gsub(/\n/,'') %></a><% if map.user %> by <
a href='/profile/<%= map.user.login %>'><%= map.user.login %></a><% end %>");
    31:         <% end %>
  app/views/maps/map.html.erb:28:in `_app_views_maps_map_html_erb___4321022319040003615_70037854414140'
  app/controllers/maps_controller.rb:22:in `map'

This needs a little debugging! Maybe where we're trying to joins users here:

mapknitter/app/controllers/maps_controller.rb

Line 20 in 61e8035

.joins(:warpables, :users)

Also see #40

[kaustubh-nair]

I'd like to take this issue, I think I can fix it!