Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic test failures #450

Closed
jywarren opened this issue Mar 31, 2020 · 3 comments
Closed

Basic test failures #450

jywarren opened this issue Mar 31, 2020 · 3 comments

Comments

@jywarren
Copy link
Member

Hi, i noticed some tests failing on the most recent build -- https://travis-ci.com/github/publiclab/leaflet-environmental-layers/builds/157234331

 Basic LEL Implementation
   - leaflet is created...✓ leaflet is created
   - baselayer is added by default...X baselayer is added by default
     TypeError: undefined is not a constructor (evaluating 'new L.Control.GPlaceAutocomplete') in file:///home/travis/build/publiclab/leaflet-environmental-layers/dist/LeafletEnvironmentalLayers_babel.js (line 5139) (1)

and more like this. Looks like maybe some assets aren't getting included? But, not sure if this is intermittent or happens every time. I'm restarting the tests to see.

@crisner
Copy link
Contributor

crisner commented Apr 2, 2020

@jywarren, it looks like Jasmine is not recognizing the search control. I tried adding it to grunt as a vendor under Jasmine's options and also in the browserify dist src file list but it did not work. Commenting out the search control seems to make the tests pass. I'll try to look into what else can be done for Jasmine to recognize the control as a constructor.

@jywarren
Copy link
Member Author

Oh hmm. Do you think it's not recognizing it or perhaps the search controller is not rendering from inside Travis because of approved-domain-name issues? I noticed the search control doesn't start up properly in https://stable.publiclab.org/map as we haven't approved stable.publiclab.org on the Google API end. Could this be the same issue?

@jywarren
Copy link
Member Author

I believe this was resolved in the switch to GitHub Actions: #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants