From b26d4b7f8b65e8d5884184e2e7f4eddd828ffe73 Mon Sep 17 00:00:00 2001 From: Olusola Date: Fri, 17 Jan 2020 16:19:41 +0100 Subject: [PATCH 1/2] fillColor getting correct color --- src/modules/PaintBucket/PaintBucket.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/PaintBucket/PaintBucket.js b/src/modules/PaintBucket/PaintBucket.js index 8257e8bf8b..f0c7919277 100644 --- a/src/modules/PaintBucket/PaintBucket.js +++ b/src/modules/PaintBucket/PaintBucket.js @@ -24,7 +24,7 @@ module.exports = exports = function(pixels, options) { minFactor = (1 - tolerance / 100); fillColor = fillColor.substring(fillColor.indexOf('(') + 1, fillColor.length - 1); // extract only the values from rgba(_,_,_,_) fillColor = fillColor.split(','); - + fillColor[3] = fillColor[3] * 256; function isSimilar(currx, curry) { return (pixels.get(currx, curry, 0) >= r * minFactor && pixels.get(currx, curry, 0) <= r * maxFactor && pixels.get(currx, curry, 1) >= g * minFactor && pixels.get(currx, curry, 1) <= g * maxFactor && From 0bb292b61c3484bc5961b078a860b62df1727264 Mon Sep 17 00:00:00 2001 From: Olusola Date: Sat, 18 Jan 2020 00:52:25 +0100 Subject: [PATCH 2/2] Fixed #1488 Corrected the multiplier from 256 to 255 --- src/modules/PaintBucket/PaintBucket.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/PaintBucket/PaintBucket.js b/src/modules/PaintBucket/PaintBucket.js index f0c7919277..f681b143ed 100644 --- a/src/modules/PaintBucket/PaintBucket.js +++ b/src/modules/PaintBucket/PaintBucket.js @@ -24,7 +24,7 @@ module.exports = exports = function(pixels, options) { minFactor = (1 - tolerance / 100); fillColor = fillColor.substring(fillColor.indexOf('(') + 1, fillColor.length - 1); // extract only the values from rgba(_,_,_,_) fillColor = fillColor.split(','); - fillColor[3] = fillColor[3] * 256; + fillColor[3] = fillColor[3] * 255; function isSimilar(currx, curry) { return (pixels.get(currx, curry, 0) >= r * minFactor && pixels.get(currx, curry, 0) <= r * maxFactor && pixels.get(currx, curry, 1) >= g * minFactor && pixels.get(currx, curry, 1) <= g * maxFactor &&