Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saturation Module not working correctly #868

Closed
mgroovyank opened this issue Mar 17, 2019 · 7 comments
Closed

Saturation Module not working correctly #868

mgroovyank opened this issue Mar 17, 2019 · 7 comments

Comments

@mgroovyank
Copy link
Member

Please describe the problem (or idea)

When you add the saturation module then instead of displaying the image with 0.5 saturation value it displays a black image.

Screenshot (3)

You can see it here:

https://sequencer.publiclab.org/examples/#steps=saturation{}

@harshkhandeparkar
Copy link
Member

Hello. Thanks for the catch but this has been already fixed but not uploaded to sequencer.publiclab.org website. Closing this. Thank you!

@mgroovyank
Copy link
Member Author

@harshkhandeparkar Thanks for update.
I don't know if this is important. But Have a look at these two links.
Is the difference of default parameter in the two links okay?

https://github.com/jywarren/image-sequencer/blob/main/src/modules/Saturation/info.json
https://github.com/publiclab/image-sequencer/blob/main/src/modules/Saturation/info.json

@harshkhandeparkar
Copy link
Member

Oh don't look at jywarren/image-sequencer. It is old. The whole repo has been shifted to publiclab/image-sequencer and jywarren's fork is around 200 commits behind. Thank you.

@harshkhandeparkar
Copy link
Member

Would you like to solve some first-timers-only issue? You haven't contributed before right?

@mgroovyank
Copy link
Member Author

@harshkhandeparkar Yeah I will do it.

@harshkhandeparkar
Copy link
Member

@mgroovyank shall I add your name to the list in #842? There are currently 0 fto issues open but there are some fto-candidate issues

@mgroovyank
Copy link
Member Author

@harshkhandeparkar yes please add my name. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants