Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FisheyeGL and WebGLDistort modules do not work with GIFs #1470

Open
harshkhandeparkar opened this issue Jan 12, 2020 · 6 comments
Open

FisheyeGL and WebGLDistort modules do not work with GIFs #1470

harshkhandeparkar opened this issue Jan 12, 2020 · 6 comments
Assignees
Labels

Comments

@harshkhandeparkar
Copy link
Member

Please describe the problem (or idea)

WebGLDistort and FisheyeGL modules which use canvas, currently only manipulate the first frame of the GIF and output a still image.
These modules do not use pixelManipulation.

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@harshkhandeparkar
Copy link
Member Author

My responsibility but if someone else wants to work on this, they can.

@ataata107
Copy link

I too would be looking into the same.

@harshkhandeparkar
Copy link
Member Author

It's not very difficult but debugging can be an issue.

@ataata107
Copy link

As extraManipulation is being called multiple times should I put the code inside extraManipulation to make it work for all the frames of gif?

@harshkhandeparkar
Copy link
Member Author

I think that should do. But these modules weirdly manipulate the pixels. Have a look at the code. It isn't as simple as it sounds. Should we do a collab here?

@ataata107
Copy link

Sounds cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants