Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading image after modules contianing external links is applied #1288

Closed
keshav234156 opened this issue Oct 30, 2019 · 7 comments · Fixed by #1388
Closed

Downloading image after modules contianing external links is applied #1288

keshav234156 opened this issue Oct 30, 2019 · 7 comments · Fixed by #1388
Labels
gci-candidate Issue being considered for gci medium

Comments

@keshav234156
Copy link
Member

keshav234156 commented Oct 30, 2019

Please Note: We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more

Downloading modules contianing external links redirects to that link.the modules that are having external links are ndvi,gamma-correction,edge-detect,dynamic,dither,convolution

the file where the changes are to be made is

$stepAll('.download-btn').on('click', () => {
for (let index = 0; index < step.linkElements.length; index++){
var element = document.createElement('a');
element.setAttribute('href', step.linkElements[index].href);
element.setAttribute('download', step.name + '.' + fileExtension(step.imgElement.src));
element.style.display = 'none';
document.body.appendChild(element);
element.click();
document.body.removeChild(element);
}
});

Untitled_ Oct 31, 2019 3_09 AM

@keshav234156

This comment has been minimized.

@keshav234156 keshav234156 changed the title Downloading modules contianing external links Downloading image after modules contianing external links is applied Oct 30, 2019
@harshkhandeparkar

This comment has been minimized.

@harshkhandeparkar

This comment has been minimized.

@keshav234156 keshav234156 added the gci-candidate Issue being considered for gci label Nov 2, 2019
@keshav234156
Copy link
Member Author

Uploaded on GCI dashboard

@SidharthBansal

This comment has been minimized.

@SidharthBansal
Copy link
Member

PUBLISHED

@SidharthBansal
Copy link
Member

Sorry I clicked on close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gci-candidate Issue being considered for gci medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants