Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs in gamma-correction module #1255

Closed
2 tasks
keshav234156 opened this issue Sep 13, 2019 · 1 comment · Fixed by #1256
Closed
2 tasks

bugs in gamma-correction module #1255

keshav234156 opened this issue Sep 13, 2019 · 1 comment · Fixed by #1256

Comments

@keshav234156
Copy link
Member

keshav234156 commented Sep 13, 2019

  • gamma-correction is not working as expected

with gamma value of 0.5 the expected output should be
download (34)
but output that is given by IS is
download (35)

what i found is that we are dividing val by defaults.adjustment which is 0.2 instead it should have been an OR operator.

var val = adjustment / defaults.adjustment;

  • slider is not working at all in gamma-correction module

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@keshav234156
Copy link
Member Author

@jywarren @harshkhandeparkar have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant