Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New preview optimization - drawing from wrong image? #1184

Closed
jywarren opened this issue Jul 26, 2019 · 3 comments · Fixed by #1573
Closed

New preview optimization - drawing from wrong image? #1184

jywarren opened this issue Jul 26, 2019 · 3 comments · Fixed by #1573

Comments

@jywarren
Copy link
Member

hi @aashna27 i tried the new beta published by @harshkhandeparkar and saw this:

image

It seems like maybe the previews are not drawing on the last step, but the first step?

http://beta.sequencer.publiclab.org/examples/#steps=dither{dither:floydsteinberg}

On the other hand, I tried the non-beta main site and it just stalled 😆 so we're already doing better 😄

image

Aha, it finally ran. But it suffers the same issue. I think the preview system may always have been connected to the initial image, instead of the final step? not sure, but we should fix this!

image

Thanks, all!

@jywarren jywarren changed the title New preview optimization - drawing from correct image? New preview optimization - drawing from wrong image? Jul 26, 2019
@harshkhandeparkar
Copy link
Member

The site doesn't load for me

SyntaxError: invalid regexp group image-sequencer.js:1:9
ReferenceError: ImageSequencer is not defined

@harshkhandeparkar
Copy link
Member

was anything changed?

@keshav234156
Copy link
Member

I am now working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants