Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI ambiguities around rotate and scale #226

Closed
4 of 5 tasks
jywarren opened this issue Apr 19, 2019 · 0 comments · Fixed by #229
Closed
4 of 5 tasks

UI ambiguities around rotate and scale #226

jywarren opened this issue Apr 19, 2019 · 0 comments · Fixed by #229
Assignees

Comments

@jywarren
Copy link
Member

jywarren commented Apr 19, 2019

Default tool: Rotate vs. Rotate+Scale

Currently the default tool with a "rotate" icon in the main index.html demo is Rotate. But Rotate+Scale should be the default - the separate Rotate and Scale tools are for downstream use in this lib: #105

Same icon issue

Both of these use the same icon, which is confusing:

  • "toggling between rotate-and-scale and distort"
  • "toggle between rotate and distort

Hotkeys

  • these should toggle between Rotate+Scale and Distort, not just Rotate
  • Naming misleading
82: "_toggleRotateDistort", // r,
68: "_toggleRotateDistort", // d

Part 2:

  • fix all hotkey usage for multiple image select. When you have multiple images hitting a hot key does not update the handles on the image you currently have selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants