Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VsTabs): change tab scroll buttons & fix bottom line 100% width #278

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

smithoo
Copy link
Collaborator

@smithoo smithoo commented Aug 29, 2024

Type of PR (check all applicable)

  • Fix Bug (fix)

Summary

vs-tabs scroll-buttons의 동작을 변경합니다

Description

  • vs-tabs scroll-buttons가 단순히 scroll만 옮기지 않고, tab 선택을 변경합니다
  • vs-tabs에 scroll이 생겼을 때 bottom line이 끝까지 render되지 않는 버그를 수정합니다
  • keyboard 동작 버그를 수정합니다
  • tab을 선택하지 않는 경우를 상정합니다

@smithoo smithoo requested a review from yeriiiii August 29, 2024 07:44
@smithoo smithoo self-assigned this Aug 29, 2024
@smithoo smithoo changed the title Fix/vs tabs fix(VsTabs): change tab scroll buttons & fix bottom line 100% width Aug 29, 2024
@smithoo smithoo merged commit 718ff8c into main Sep 9, 2024
8 of 10 checks passed
@smithoo smithoo deleted the fix/vs-tabs branch September 9, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants