Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning due to a upgrade react-native to 0.26 [using key props] #75

Closed
oziks opened this issue May 20, 2016 · 1 comment
Closed

Warning due to a upgrade react-native to 0.26 [using key props] #75

oziks opened this issue May 20, 2016 · 1 comment

Comments

@oziks
Copy link

oziks commented May 20, 2016

I attempt to upgrade to react-native 0.26 but a warning message appears.
I explain you my workflow :

  • react-native: 0.26
  • react: 15.0.2
  • react-native-router-flux: #master

The warning message is

Warning: Element: `key` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop. (https://fb.me/react-special-props)

on this line https://github.com/exponentjs/react-native-tab-navigator/blob/master/TabNavigator.js#L48.

According to https://fb.me/react-special-props, using key props is not a good idea.

@ide
Copy link
Contributor

ide commented May 20, 2016

That's kind of annoying... semantically we actually want the same value as the key prop. One thing that's confusing is we're accessing element.key instead of element.props.key -> need to investigate this more.

@oziks oziks closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants