Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot decompress file that is not an archive #5034

Closed
3 tasks done
EpicPlayerA10 opened this issue Mar 15, 2024 · 2 comments · Fixed by pterodactyl/wings#184
Closed
3 tasks done

Cannot decompress file that is not an archive #5034

EpicPlayerA10 opened this issue Mar 15, 2024 · 2 comments · Fixed by pterodactyl/wings#184
Labels
bug Something that's not working as it's intended to be.

Comments

@EpicPlayerA10
Copy link

EpicPlayerA10 commented Mar 15, 2024

Current Behavior

When I try to unarchive minecraft log file (example: /logs/2024-03-15-2.log.gz) then it wouldn't work and on the planel it would show this error:
image

On wings it will throw this error:

wings[1917041]: 2024/03/15 22:32:22 [Recovery] 2024/03/15 - 22:32:22 panic recovered:
wings[1917041]: runtime error: invalid memory address or nil pointer dereference
wings[1917041]: runtime/panic.go:261 (0x451e97)
wings[1917041]: runtime/signal_unix.go:861 (0x451e65)
wings[1917041]: io/fs/stat.go:25 (0x504716)
wings[1917041]: io/fs/walk.go:118 (0x504c95)
wings[1917041]: github.com/pterodactyl/wings/server/filesystem/compress.go:113 (0xe532a4)
wings[1917041]: github.com/pterodactyl/wings/router/router_server_files.go:450 (0xfde38f)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:158 (0xfe51c8)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:186 (0xfe503c)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:186 (0xfe4dfc)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xfa99dd)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/logger.go:240 (0xfa99a0)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:51 (0xfd75e4)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:42 (0xfd7638)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xfb405c)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:135 (0xfb404a)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:68 (0xfe4686)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xf9db8a)
wings[1917041]: github.com/pterodactyl/wings/router/middleware/middleware.go:33 (0xfe4638)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xfaa839)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/recovery.go:102 (0xfaa827)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/context.go:174 (0xfa8a9a)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/gin.go:620 (0xfa872d)
wings[1917041]: github.com/gin-gonic/gin@v1.9.1/gin.go:576 (0xfa825c)
wings[1917041]: net/http/server.go:2938 (0x6ea24d)
wings[1917041]: net/http/server.go:2009 (0x6e6133)
wings[1917041]: runtime/asm_amd64.s:1650 (0x470dc0)

Expected Behavior

Minecraft log file should be unarchived.

Steps to Reproduce

  1. Setup minecraft server and start it
  2. Try to unarchive one of the log files
  3. See the error

Panel Version

1.11.5

Wings Version

1.11.11

Games and/or Eggs Affected

Minecraft (Paper)

Docker Image

ghcr.io/pterodactyl/yolks:java_17

Error Logs

No response

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
@EpicPlayerA10 EpicPlayerA10 added the not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. label Mar 15, 2024
@matthewpi matthewpi added bug Something that's not working as it's intended to be. and removed not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. labels Mar 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Backlog Mar 16, 2024
@matthewpi matthewpi moved this from 🆕 New to 📋 Backlog in Backlog Mar 16, 2024
@matthewpi matthewpi changed the title Can't unarchive minecraft log file (.log.gz) Cannot decompress file that is not an archive Mar 17, 2024
@matthewpi matthewpi moved this from 📋 Backlog to 🧨 Awaiting release in Backlog Mar 17, 2024
@NotGeri
Copy link

NotGeri commented Mar 26, 2024

I know this hasn't been released yet, but as far as I can tell, the patch introduced in pterodactyl/wings@f1c5bbd does not work yet

It no longer panics, but it can't cast here: https://github.com/pterodactyl/wings/blob/f1c5bbd42d423986e7017b4f3c43057a1b7d1717/server/filesystem/compress.go#L194-L197

I may be misunderstanding but the Gz doesn't seem to implement Extractor, just Compressor

I will see if I can find out more in the meantime

@danny6167
Copy link
Member

Confirmed this is still not working on the latest release and latest develop branch - Reopening.

@danny6167 danny6167 reopened this May 5, 2024
@github-project-automation github-project-automation bot moved this from 🧨 Awaiting release to 🆕 New in Backlog May 5, 2024
@danny6167 danny6167 moved this from 🆕 New to 🎉 Released in Backlog May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants