-
-
Notifications
You must be signed in to change notification settings - Fork 62
-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change date format #68
Comments
Personally I don't have issues with using a simple unix timestamp.
When dumping a backup to a file and use it on other filesystems I don't think it is handy to have colons in the filename. |
Well its not set in stone. I dont want to use characters that need escaping or change to slashes. :) And offcourse it will stay backwards compatible with the old existing snapshots. If everybody just loves the current format, I wont change it. :) |
If you are going to change the format, I would recommend looking at ISO 8601 where the letter 'T' is specified as the separator. ZnapZend uses 2021-01-12T14:00:00, but 20210112T140000 is also allowed if you don't want colons. |
I like ZnapZend's format. Is it still iso 8601 compatible? |
Yes. I believe both examples above are compatible. It doesn't help with mariusvw's concerns above. Does the programming even depend on the snapshot name? Perhaps it could be "%Y-%m-%dT%H:%M:%S" by default but customizable? Personally, coming from ZnapZend myself, I'm a bit thrown by having the backup job name as part of the snapshot. But it seems the programming might require that. |
@tpyro the backup name in the snapshot has two reasons:
|
I just added the --snapshot-format option to fix #87 . So that essentially fixes this as well. The default format stayed the same offcourse to keep it compatible. |
The current date/time format is pretty unreadable.
Change it to:
pool/dataset@snapname_2021-02-10_12:49.00
The text was updated successfully, but these errors were encountered: