Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent mounting #112

Closed
psy0rz opened this issue Jan 25, 2022 · 6 comments
Closed

More consistent mounting #112

psy0rz opened this issue Jan 25, 2022 · 6 comments
Labels
Milestone

Comments

@psy0rz
Copy link
Owner

psy0rz commented Jan 25, 2022

See #108

  • zfs create doesnt use the -u flag
  • zfs recv DOES use the -u flag

I think we should mount a received filesystem only if canmount=on and it has a mountpoint, as to make that part consistent behaviour. ( and make it keep in mind --clear-mountpoint as well)

Not sure what to do with created parents yet. (mounting a parent may invoke changes on an even higher parent since it will create the mountpoint as well)

@psy0rz psy0rz added the bug label Jan 25, 2022
@psy0rz psy0rz added this to the 3.2 milestone Jan 25, 2022
@psy0rz
Copy link
Owner Author

psy0rz commented Jun 6, 2023

also we should update the documentation to explain that clear-mountpoint will result in either:

  • a directory getting created in the parent dataset, thus creating a change. (needing a rollback or --force)
  • a "failed to create mountpoint: Read-only file system" if the parent dataset is readonly. (which is usually recommented)

@psy0rz psy0rz closed this as completed in 771127d Sep 26, 2023
@psy0rz
Copy link
Owner Author

psy0rz commented Sep 26, 2023

i made some pretty big changes:

  • when we need to create empty parent datasets, they now have canmount=off. this is hopefully less annoying and more consistent.
  • after an initial transfer we now simulate an "zfs mount -a" for that specific dataset, so that behaviour is consistent with a reboot.

since this is pretty different behaviour, i think this warrants a major release version.

@psy0rz
Copy link
Owner Author

psy0rz commented Sep 26, 2023

(also broke some stuff)

@psy0rz
Copy link
Owner Author

psy0rz commented Oct 5, 2023

@exptom
Copy link

exptom commented Jan 12, 2024

@psy0rz any ETA on when this might make it into a release? I'm hitting issues with doing non-root backups and the parent datasets throwing an error because they are defaulting to canmount=on when created by zfs-autobackup

@psy0rz
Copy link
Owner Author

psy0rz commented Jan 15, 2024

i'll try to release 3.3 beta soon, which has this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants