From 88ccdea6fc212fa99143f7617eb0286f49a49ba4 Mon Sep 17 00:00:00 2001 From: Manu NALEPA Date: Tue, 19 Mar 2024 00:35:19 +0100 Subject: [PATCH] Make deepsource happy. --- beacon-chain/p2p/broadcaster.go | 12 ++++++------ beacon-chain/p2p/subnets.go | 6 ++++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/beacon-chain/p2p/broadcaster.go b/beacon-chain/p2p/broadcaster.go index ee2e74b0626c..10b209390800 100644 --- a/beacon-chain/p2p/broadcaster.go +++ b/beacon-chain/p2p/broadcaster.go @@ -69,7 +69,7 @@ func (s *Service) BroadcastAttestation(ctx context.Context, subnet uint64, att * } // Non-blocking broadcast, with attempts to discover a subnet peer if none available. - go s.broadcastAttestation(ctx, subnet, att, forkDigest) + go s.internalBroadcastAttestation(ctx, subnet, att, forkDigest) return nil } @@ -95,8 +95,8 @@ func (s *Service) BroadcastSyncCommitteeMessage(ctx context.Context, subnet uint return nil } -func (s *Service) broadcastAttestation(ctx context.Context, subnet uint64, att *ethpb.Attestation, forkDigest [4]byte) { - _, span := trace.StartSpan(ctx, "p2p.broadcastAttestation") +func (s *Service) internalBroadcastAttestation(ctx context.Context, subnet uint64, att *ethpb.Attestation, forkDigest [4]byte) { + _, span := trace.StartSpan(ctx, "p2p.internalBroadcastAttestation") defer span.End() ctx = trace.NewContext(context.Background(), span) // clear parent context / deadline. @@ -222,13 +222,13 @@ func (s *Service) BroadcastBlob(ctx context.Context, subnet uint64, blob *ethpb. } // Non-blocking broadcast, with attempts to discover a subnet peer if none available. - go s.broadcastBlob(ctx, subnet, blob, forkDigest) + go s.internalBroadcastBlob(ctx, subnet, blob, forkDigest) return nil } -func (s *Service) broadcastBlob(ctx context.Context, subnet uint64, blobSidecar *ethpb.BlobSidecar, forkDigest [4]byte) { - _, span := trace.StartSpan(ctx, "p2p.broadcastBlob") +func (s *Service) internalBroadcastBlob(ctx context.Context, subnet uint64, blobSidecar *ethpb.BlobSidecar, forkDigest [4]byte) { + _, span := trace.StartSpan(ctx, "p2p.internalBroadcastBlob") defer span.End() ctx = trace.NewContext(context.Background(), span) // clear parent context / deadline. diff --git a/beacon-chain/p2p/subnets.go b/beacon-chain/p2p/subnets.go index 391229a18526..03b68a6b225e 100644 --- a/beacon-chain/p2p/subnets.go +++ b/beacon-chain/p2p/subnets.go @@ -212,8 +212,10 @@ func initializePersistentSubnets(id enode.ID, epoch primitives.Epoch) error { // // return [compute_subscribed_subnet(node_id, epoch, index) for index in range(SUBNETS_PER_NODE)] func computeSubscribedSubnets(nodeID enode.ID, epoch primitives.Epoch) ([]uint64, error) { - subs := []uint64{} - for i := uint64(0); i < params.BeaconConfig().SubnetsPerNode; i++ { + subnetsPerNode := params.BeaconConfig().SubnetsPerNode + subs := make([]uint64, 0, subnetsPerNode) + + for i := uint64(0); i < subnetsPerNode; i++ { sub, err := computeSubscribedSubnet(nodeID, epoch, i) if err != nil { return nil, err