Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all Orpheus code/hard coded strings into config file options #56

Open
nateinaction opened this issue Dec 19, 2024 · 3 comments · May be fixed by #64
Open

Move all Orpheus code/hard coded strings into config file options #56

nateinaction opened this issue Dec 19, 2024 · 3 comments · May be fixed by #64
Assignees
Labels
good first issue Good for newcomers

Comments

@nateinaction
Copy link
Member

Read a config file at boot that can:

  • name the satellite
  • set the radio callsign
  • set all the jokes that can be beaconed
@nateinaction nateinaction added the good first issue Good for newcomers label Dec 19, 2024
@Alandlt15 Alandlt15 self-assigned this Dec 20, 2024
@Alandlt15
Copy link

On the branch 'config-file', I created the config file and added the stuff mentioned.
Not sure if that's exactly how its supposed to go so feel free to correct me if needed.

@nateinaction
Copy link
Member Author

This is a good start. I like that you're isolating these config lines into their own file. I saw your comments # might need to config these as well I think that's a good idea for this PR. Go ahead and tackle at least the rest of that block of variable declarations!

For the next phase in moving these hard coded values to config what about using something like configparser or json? It looks like both are built-in python libraries included in python 3.0 so they should be supported in circuit python. I'm leaning toward json since it is more common than INI. What do you think?

@Alandlt15
Copy link

I will go ahead and get the rest of the variable declarations migrated.

And absolutely! I'm on board with using json although I'm gonna do some research and try to find out the pros and cons of both if any.

@Mikefly123 Mikefly123 linked a pull request Dec 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants