Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict marker send(including bank send) and marker transfer based on the presence of a certain attribute or attributes #1310

Closed
4 tasks
arnabmitra opened this issue Jan 18, 2023 · 1 comment

Comments

@arnabmitra
Copy link
Contributor

arnabmitra commented Jan 18, 2023

Summary

Restrict marker send(including bank send) and marker transfer based on the presence of a certain attribute/attributes

Problem Definition

As a marker admin, i may only want a send of a non restricted marker to another user (normal bank send) if and only if they(receiver) has a certain attribute. This assumes that a withdraw also enforces the attribute check so that the sender always has that attribute(maybe optional?)
For a restricted marker want the same, except the path is via marker transfer

Why do we need this feature?

To help Dapps/SC's restrict transfers with greater checks. e.g only let transfer/sends to happen to kyc'ed parties.

What benefits does the Provenance Network stand to gain by including this feature?

Right now SC's/Dapps are checking this at their level, this makes it a protocol level feature.

Are there any disadvantages of including this feature?

More complexity and more paths to check.

Proposal

1.Leverage bank send restrictions put in by another PR to achieve this for non restricted markers.
2.Add checks on marker#transfer method to also achieve above.
3. ibc-go may need a check too, but i am unclear.
4.SC flow should be automatically achieved if 1 & 2 are implemented i think.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@arnabmitra arnabmitra changed the title restrict marker send(including bank send) and marker transfer based on the presence of a certain attribute Restrict marker send(including bank send) and marker transfer based on the presence of a certain attribute Jan 18, 2023
@arnabmitra arnabmitra changed the title Restrict marker send(including bank send) and marker transfer based on the presence of a certain attribute Restrict marker send(including bank send) and marker transfer based on the presence of a certain attribute or attributes Jan 18, 2023
@arnabmitra
Copy link
Contributor Author

duplicate #1256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant