Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion error in protoc.exe built by VS2017: CHECK failed: file != NULL #4874

Closed
jtattermusch opened this issue Jul 6, 2018 · 5 comments
Closed

Comments

@jtattermusch
Copy link
Contributor

jtattermusch commented Jul 6, 2018

protoc v3.6.0 on windows (built using VS2017)

protoc.exe  --grpc_out=generate_mock_code=true:C:/Users/jtattermusch/github/grpc/cmake/build/gens --cpp_out=C:/Users/jtattermusch/github/grpc/cmake/build/gens --plugin=protoc-gen-grpc=C:/Users/jtattermusch/github/grpc/cmake/build/Debug/grpc_cpp_plugin.exe -I . -I C:/Users/jtattermusch/github/grpc/third_party/protobuf/src src/proto/grpc/health/v1/health.proto                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       protoc.exe

crashes with an assertion:
[libprotobuf FATAL C:\Users\jtattermusch\github\grpc\third_party\protobuf\src\google\protobuf\generated_message_reflection.cc:2372] CHECK failed: file != NULL

@jtattermusch
Copy link
Contributor Author

jtattermusch commented Jul 6, 2018

Minimal repro:
protoc.exe --cpp_out=. src/proto/grpc/health/v1/health.proto (using health.proto from grpc's repo https://github.com/grpc/grpc/blob/master/src/proto/grpc/health/v1/health.proto)
still crashes with the same assertion error.

https://github.com/google/protobuf/blob/79700b56b99fa5c8c22ddef78e6c9557ff711379/src/google/protobuf/generated_message_reflection.cc#L2372

@sigiesec
Copy link

sigiesec commented Jul 6, 2018

I think this is the same as #4773

@jtattermusch
Copy link
Contributor Author

Interestingly, when building with VS2015, I don't see protoc crashing - I only see it for VS2017 (see grpc's build https://source.cloud.google.com/results/invocations/1322c557-38df-4b30-b5bc-a1d70f21a93d/targets/github%2Fgrpc%2Faggregate_tests/tests;passed=true)

@jtattermusch
Copy link
Contributor Author

@sigiesec you're right, thanks! There seems to be a fix for this in progress, I'll try to expedite it and push for protobuf 3.6.1 patch release.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jul 6, 2018

Closing as this is a duplicate of #4773

@xfxyjwf xfxyjwf closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants