Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake files are not installed when built with autoconf #11545

Closed
a-andre opened this issue Jan 13, 2023 · 2 comments
Closed

CMake files are not installed when built with autoconf #11545

a-andre opened this issue Jan 13, 2023 · 2 comments
Assignees
Labels

Comments

@a-andre
Copy link

a-andre commented Jan 13, 2023

CMake is planning to deprecated `FindProtobuf in favour of the cmake files provided by protobuf, because it is difficult to maintain compatibility with protobuf's cmake files, see [1] and [2] But that relies on distributions shipping these cmake files. Some distributions, like Debian or Fedora, don't ship the files, yet, because the distributions are using autoconf to build protobuf.

Please install CMake files when using autoconf+make install or remove autoconf files from release tarballs to force distributions to provide protobuf's CMake files.

What version of protobuf and what language are you using?
Version: v21.12
Language: C++/Java/Python/C#/Ruby/PHP/Objective-C/Javascript

What operating system (Linux, Windows, ...) and version?
Arch Linux

What runtime / compiler are you using (e.g., python version or gcc version)

What did you do?
Steps to reproduce the behavior:

  1. Extract protobuf tarball (https://github.com/protocolbuffers/protobuf/releases/download/v21.12/protobuf-cpp-3.21.12.tar.gz)
  2. ./configure
  3. make
  4. make install

What did you expect to see
CMake files installed, like it is done when using CMake to build protobuf.

What did you see instead?
No cmake files installed.

Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).

Anything else we should know about your project / environment

@a-andre a-andre added the untriaged auto added to all issues by default when created. label Jan 13, 2023
@mkruskal-google mkruskal-google self-assigned this Jan 14, 2023
@mkruskal-google mkruskal-google added cmake and removed untriaged auto added to all issues by default when created. labels Jan 14, 2023
@mkruskal-google
Copy link
Member

We've removed autotools support as of #10132 and will no longer be shipping those configs. The only supported mechanism for system installation in 22.x and beyond will be cmake. Note, you can also use cmake to install protobuf in 21.x, in which case the cmake files should get set up properly.

Given that we plan to release 22.x in the next few weeks, I'm going to close this. Let me know if you have some more specific need for this in 21.x w/ autotools though.

@a-andre
Copy link
Author

a-andre commented Jan 14, 2023

Thanks, that information helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants