Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow message.getTypeUrl provide custom typeUrlPrefix #1762

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

kairlec
Copy link
Contributor

@kairlec kairlec commented Jul 7, 2022

I noticed that in many other language implementations (such as Java, CSharp), Google provides optional parameter typeUrlPrefix for the function pack or getTypeUrl


this pr is a re-request of #1665 , the original pr was mistakenly overwritten by the force push of the pull bot

@alexander-fenster alexander-fenster changed the title feat: allow message.getTypeUrl provide custom tyepUrlPrefix feat: allow message.getTypeUrl provide custom typeUrlPrefix Jul 7, 2022
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Now that we have some test coverage for CLI tools, I added a test (and regenerated part of the test files which was generated, so this added some extra files to this PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants