Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in deisotoper #66

Closed
LucasSchmidt97 opened this issue Nov 16, 2017 · 3 comments
Closed

Fix bug in deisotoper #66

LucasSchmidt97 opened this issue Nov 16, 2017 · 3 comments
Assignees

Comments

@LucasSchmidt97
Copy link
Collaborator

(2) [ 642.572 643.569 ]
(9) [ 643.569 644.557 ]
Output Peaklist:
642.572 17000.0
643.054 25000.0
643.569 12000.0
643.569 12000.0
644.062 9000.0
644.557 4000.0

(1) [ 642.572 643.054 643.569 ]
(9) [ 643.569 644.557 ]
Output Peaklist:
642.572 17000.0
643.054 25000.0
643.569 12000.0
643.569 12000.0
644.062 9000.0
644.557 4000.0

(0) [ 642.572 643.054 ]
(9) [ 643.569 644.557 ]
Output Peaklist:
642.572 17000.0
643.054 25000.0
643.569 12000.0
644.062 9000.0
644.557 4000.0

Same input, different output.

Why?
How to fix?

@LucasSchmidt97
Copy link
Collaborator Author

(0) [ 642.572 643.054 ]
(1) [ 642.572 643.054 643.569 ]
(2) [ 642.572 643.569 ]
(3) [ 642.572 643.569 644.557 ]
(4) [ 643.054 643.569 ]
(5) [ 643.054 643.569 644.062 ]
(6) [ 643.054 644.062 ]
(7) [ 643.569 644.062 ]
(8) [ 643.569 644.062 644.557 ]
(9) [ 643.569 644.557 ]
(10) [ 644.062 644.557 ]
bp (2) [ 642.572 643.569 ]
bp (9) [ 643.569 644.557 ]
Output Peaklist:
642.572 17000.0
643.054 25000.0
643.569 12000.0
643.569 12000.0
644.062 9000.0
644.557 4000.0

(0) [ 642.572 643.054 ]
(1) [ 642.572 643.054 643.569 ]
(2) [ 642.572 643.569 ]
(3) [ 642.572 643.569 644.557 ]
(4) [ 643.054 643.569 ]
(5) [ 643.054 643.569 644.062 ]
(6) [ 643.054 644.062 ]
(7) [ 643.569 644.062 ]
(8) [ 643.569 644.062 644.557 ]
(9) [ 643.569 644.557 ]
(10) [ 644.062 644.557 ]
bp (1) [ 642.572 643.054 643.569 ]
bp (9) [ 643.569 644.557 ]
Output Peaklist:
642.572 17000.0
643.054 25000.0
643.569 12000.0
643.569 12000.0
644.062 9000.0
644.557 4000.0

(0) [ 642.572 643.054 ]
(1) [ 642.572 643.054 643.569 ]
(2) [ 642.572 643.569 ]
(3) [ 642.572 643.569 644.557 ]
(4) [ 643.054 643.569 ]
(5) [ 643.054 643.569 644.062 ]
(6) [ 643.054 644.062 ]
(7) [ 643.569 644.062 ]
(8) [ 643.569 644.062 644.557 ]
(9) [ 643.569 644.557 ]
(10) [ 644.062 644.557 ]
bp (0) [ 642.572 643.054 ]
bp (9) [ 643.569 644.557 ]
Output Peaklist:
642.572 17000.0
643.054 25000.0
643.569 12000.0
644.062 9000.0
644.557 4000.0

@LucasSchmidt97
Copy link
Collaborator Author

LucasSchmidt97 commented Nov 17, 2017

Bug might be in bestPath ...

Update: Bug is caused by scoring, the input doesn't get scored (every path has score 1), the test data is causing this.

@LucasSchmidt97
Copy link
Collaborator Author

Isn't a real bug, the input data is just not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant