Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Add tests #40

Closed
kriswep opened this issue Nov 4, 2017 · 2 comments
Closed

[V1] Add tests #40

kriswep opened this issue Nov 4, 2017 · 2 comments

Comments

@kriswep
Copy link
Contributor

kriswep commented Nov 4, 2017

We need a sufficient enough test suite to be able to be confident about future refactors.

The test framework / runner needs to be discussed.

tape was mentioned, which is known to be a quite lightweight solution. However, in my opinion, adding things like mock suppport needs more configuration to work.

I also would like to add jest to the discussion, which is more a batteries included solution. Nice features are integrated snapshot testing (good for APIs), mocking and a quick interactive watch mode.

More opinions on test runners/framework welcome.

Also desirable would be some kind of CI setup, eg travis

@kriswep
Copy link
Contributor Author

kriswep commented Nov 5, 2017

as a reference I added a first test suite implementation in #44.

@dereklieu
Copy link
Member

Thanks @kriswep. Let's ticket out additional test coverage requests/to-dos separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants