From 8b3d7173bd47fb9b96a28bdf67bc1d0a6dc82516 Mon Sep 17 00:00:00 2001 From: Nam Pham Date: Mon, 1 Jul 2019 13:49:48 +0700 Subject: [PATCH 1/2] Bitbucket deprecated its API v1.0: update all endpoints to API v2.0 (pull_requests wasn't updated) --- lib/pronto/clients/bitbucket_client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pronto/clients/bitbucket_client.rb b/lib/pronto/clients/bitbucket_client.rb index 5efd1e45..219bc0c7 100644 --- a/lib/pronto/clients/bitbucket_client.rb +++ b/lib/pronto/clients/bitbucket_client.rb @@ -21,7 +21,7 @@ def pull_comments(slug, pull_id) end def pull_requests(slug) - response = get("#{pull_request_api(slug)}/pullrequests?state=OPEN") + response = get("/#{slug}/pullrequests?state=OPEN") openstruct(response['values']) end From 133c353556ecc2807b67d45018f82052e2bf8a87 Mon Sep 17 00:00:00 2001 From: Nam Pham Date: Mon, 1 Jul 2019 15:21:07 +0700 Subject: [PATCH 2/2] Fix issue of approve_pull_request and unapprove_pull_request method --- lib/pronto/clients/bitbucket_client.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pronto/clients/bitbucket_client.rb b/lib/pronto/clients/bitbucket_client.rb index 219bc0c7..827463ee 100644 --- a/lib/pronto/clients/bitbucket_client.rb +++ b/lib/pronto/clients/bitbucket_client.rb @@ -30,11 +30,11 @@ def create_pull_comment(slug, pull_id, body, path, position) end def approve_pull_request(slug, pull_id) - self.class.post("#{slug}/pullrequests/#{pull_id}/approve") + self.class.post("/#{slug}/pullrequests/#{pull_id}/approve") end def unapprove_pull_request(slug, pull_id) - self.class.delete("#{slug}/pullrequests/#{pull_id}/approve") + self.class.delete("/#{slug}/pullrequests/#{pull_id}/approve") end private