Github review comment should be "REQUEST_CHANGES" mode

[rnitta]

pronto/lib/pronto/github.rb

Line 52 in 899c6f2

event: 'COMMENT',

Now it is submitted with "COMMENT" mode.
it should be "REQUEST_CHANGES" (and this is also semantic).

Or, the mode should be selectable by user.

thoughts?

see also:
https://octokit.github.io/octokit.rb/Octokit/Client/Reviews.html#create_pull_request_review-instance_method
https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review

[mikegee]

seems legit to me 👍

[mknapik]

I like the idea of submitting as Request Changes but making it default and only option seems to be pretty arbitrary.
I think it would be better to make the mode configurable so we don't impose any particular workflow on users.

[mmozuras]

I agree with @mknapik - "request changes" makes sense as the default and I think that we should be it configurable.

[ashkulz]

This has been implemented.