Pronto-reek comments on files that are in exclude_paths

[ibrahima]

Currently, pronto-reek will still check and comment on files that are in exclude_paths in your reek configuration. It seems like pronto-reek should be somehow setting the force_exclusion option to true as introduced in troessner/reek#1200 .

I'll introduce a PR if I have time!

[ibrahima]

Actually, I'm not totally sure if there's a way for API consumers to set that option, it seems like a CLI only option right now. And it doesn't seem like there's any way to pass a CLI::Options object to Reek::Examiner.

[mvz]

Yes, it only influences how the CLI converts the paths given on the command line into a set of file paths to process. The Examiner object does not look at exclusions at all.

Your best bet for now is probably to check the current file against configuration.excluded_paths yourself.

[ibrahima]

Good point, we can definitely do that within pronto-reek.

[timseal]

I got round this by adding the excluded directories to the .pronto.yml file:

reek:
  exclude:
    - 'db/**/*'