Requesting payment methods not optimal

[remcotolsma]

To retrieve the available payment methods we currently do 6 requests:

wp-pronamic-pay-mollie/src/Gateway.php

Lines 113 to 170 in 8444f3a

	/**
	* Get available payment methods.
	*
	* @see Core_Gateway::get_available_payment_methods()
	* @return array<int, string>
	*/
	public function get_available_payment_methods() {
	$payment_methods = [];
	$resources = [ ResourceType::PAYMENTS, ResourceType::ORDERS ];
	$sequence_types = [ Sequence::ONE_OFF, Sequence::RECURRING, Sequence::FIRST ];
	$results = [];
	foreach ( $resources as $resource ) {
	foreach ( $sequence_types as $sequence_type ) {
	// Get active payment methods for Mollie account.
	$result = $this->client->get_payment_methods( $sequence_type, $resource );
	if ( Sequence::FIRST === $sequence_type ) {
	foreach ( $result as $method => $title ) {
	unset( $result[ $method ] );
	// Get WordPress payment method for direct debit method.
	$method = Methods::transform_gateway_method( $method );
	$payment_method = array_search( $method, PaymentMethods::get_recurring_methods(), true );
	if ( $payment_method ) {
	$results[ $payment_method ] = $title;
	}
	}
	}
	if ( is_array( $result ) ) {
	$results = array_merge( $results, $result );
	}
	}
	}
	// Transform to WordPress payment methods.
	foreach ( $results as $method => $title ) {
	$method = (string) $method;
	$payment_method = Methods::transform_gateway_method( $method );
	if ( PaymentMethods::is_recurring_method( $method ) ) {
	$payment_method = $method;
	}
	if ( null !== $payment_method ) {
	$payment_methods[] = (string) $payment_method;
	}
	}
	$payment_methods = array_unique( $payment_methods );
	return $payment_methods;
	}

wp-pronamic-pay-mollie/tests/src/GatewayTest.php

Lines 59 to 64 in 8444f3a

	$this->factory->fake( 'https://api.mollie.com/v2/methods?includeWallets=applepay&resource=payments&sequenceType=oneoff', __DIR__ . '/../http/api-mollie-com-v2-methods-oneoff.http' );
	$this->factory->fake( 'https://api.mollie.com/v2/methods?includeWallets=applepay&resource=payments&sequenceType=recurring', __DIR__ . '/../http/api-mollie-com-v2-methods-recurring.http' );
	$this->factory->fake( 'https://api.mollie.com/v2/methods?includeWallets=applepay&resource=payments&sequenceType=first', __DIR__ . '/../http/api-mollie-com-v2-methods-recurring.http' );
	$this->factory->fake( 'https://api.mollie.com/v2/methods?includeWallets=applepay&resource=orders&sequenceType=oneoff', __DIR__ . '/../http/api-mollie-com-v2-methods-oneoff.http' );
	$this->factory->fake( 'https://api.mollie.com/v2/methods?includeWallets=applepay&resource=orders&sequenceType=recurring', __DIR__ . '/../http/api-mollie-com-v2-methods-recurring.http' );
	$this->factory->fake( 'https://api.mollie.com/v2/methods?includeWallets=applepay&resource=orders&sequenceType=first', __DIR__ . '/../http/api-mollie-com-v2-methods-recurring.http' );

This is not optimal and we can simplify it in the future via, for example, https://docs.mollie.com/reference/v2/methods-api/list-all-methods.

This is also related to the following issue:

• Gateways / payment methods input fields API wp-pronamic-pay#154

[remcotolsma]

This is fixed / simplified in aba5a4f.