Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export available entropy #187

Closed
RichiH opened this issue Jan 12, 2016 · 5 comments
Closed

Export available entropy #187

RichiH opened this issue Jan 12, 2016 · 5 comments

Comments

@RichiH
Copy link
Member

RichiH commented Jan 12, 2016

It would be nice if /proc/sys/kernel/random/entropy_avail was exported as well.

Opinions?

@brian-brazil
Copy link
Contributor

Seems reasonable.

@grobie
Copy link
Member

grobie commented Jan 12, 2016

@RichiH
Copy link
Member Author

RichiH commented Jan 12, 2016

RichiH@c696546 does not add the correct values, but is as far as I got today.

And yes, it's the first time I tried doing anything in Go.

@RichiH
Copy link
Member Author

RichiH commented Jan 13, 2016

Please see https://github.com/RichiH/node_exporter/tree/playground/entropy

Open issues:

  • Cleanup
  • Even if I put 1338 into collector/fixtures/proc/sys/kernel/random/entropy_avail the test passes
    • Negative tests might be a good idea to catch such things
  • readUintFromFile() should probably be factored out into someplace else
  • @pborzenkov might want to consider switching Add new collector exposing 'ksmd' stats #165 onto the same function; it's where I stole my initial version and the current test code from

@RichiH
Copy link
Member Author

RichiH commented Jan 13, 2016

#190

@RichiH RichiH closed this as completed Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants