Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /sys/class/thermal collector #1343

Closed
SuperQ opened this issue May 12, 2019 · 5 comments
Closed

Implement /sys/class/thermal collector #1343

SuperQ opened this issue May 12, 2019 · 5 comments
Labels
enhancement good first issue help wanted platform/Linux Linux specific issue

Comments

@SuperQ
Copy link
Member

SuperQ commented May 12, 2019

Now that procfs supports /sys/class/thermal we can implement it as a new node_exporter collector.
@ilmanzo
Copy link

ilmanzo commented May 15, 2019 •
edited
Loading

do you mean reading /sys/class/thermal/thermal_zone0/temp ? What if more than one thermal zone is available, should they be numbered or referenced by a name ? How about cooling_devices ?

@SuperQ
Copy link
Member Author

SuperQ commented May 15, 2019

Yes, we would want to label them by zone number. The cooling_devices would need to be implemented in the procfs library first.

@ilmanzo
Copy link

ilmanzo commented May 15, 2019 •
edited
Loading

ok if you agree I'll try to have a look on it; are there some guidelines on how to implement a new collector ?

@ilmanzo ilmanzo mentioned this issue May 17, 2019
Closed
@davemcphee davemcphee mentioned this issue Jul 15, 2019
Merged
@pgier
Copy link
Contributor

pgier commented Aug 19, 2019

I think this can be closed since it was fixed by #1425

@mikea
Copy link

mikea commented Aug 23, 2019

Can we have a release with this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted platform/Linux Linux specific issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implementation of thermal zones collector
5 participants
@mikea @pgier @discordianfish @SuperQ @ilmanzo