From 6f0fec72e3e0d00b3127f58779fe8a2e482ba3fb Mon Sep 17 00:00:00 2001 From: Sho Ishii Date: Fri, 16 Oct 2020 00:50:16 +0900 Subject: [PATCH 1/2] fix log output of collect[] params Signed-off-by: Sho Ishii --- mysqld_exporter.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mysqld_exporter.go b/mysqld_exporter.go index 58493768..3b5f43bd 100644 --- a/mysqld_exporter.go +++ b/mysqld_exporter.go @@ -23,6 +23,7 @@ import ( "os" "path" "strconv" + "strings" "time" "github.com/go-kit/kit/log" @@ -195,7 +196,7 @@ func newHandler(metrics collector.Metrics, scrapers []collector.Scraper, logger r = r.WithContext(ctx) } } - level.Debug(logger).Log("msg", "collect[] params", "params", params) + level.Debug(logger).Log("msg", "collect[] params", "params", strings.Join(params, "+")) // Check if we have some "collect[]" query parameters. if len(params) > 0 { From 9d659fdf0d38b55a1daff4e7c7114b69a36e910c Mon Sep 17 00:00:00 2001 From: Sho Ishii Date: Sat, 17 Oct 2020 00:58:49 +0900 Subject: [PATCH 2/2] change delimiter Signed-off-by: Sho Ishii --- mysqld_exporter.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mysqld_exporter.go b/mysqld_exporter.go index 3b5f43bd..87ccf35d 100644 --- a/mysqld_exporter.go +++ b/mysqld_exporter.go @@ -196,7 +196,7 @@ func newHandler(metrics collector.Metrics, scrapers []collector.Scraper, logger r = r.WithContext(ctx) } } - level.Debug(logger).Log("msg", "collect[] params", "params", strings.Join(params, "+")) + level.Debug(logger).Log("msg", "collect[] params", "params", strings.Join(params, ",")) // Check if we have some "collect[]" query parameters. if len(params) > 0 {