Skip to content

Commit 22f42da

Browse files
committed
Add _total suffix to counter metrics, update changelog
Signed-off-by: Roman Vynar <roman.vynar@quiq.com>
1 parent 7216391 commit 22f42da

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@
1010
* [FEATURE]
1111

1212
* [FEATURE] Add `tls.insecure-skip-verify` flag to ignore tls verification errors (PR #417) #348
13+
* [FEATURE] Add new metrics to `replication_group_member_stats` collector to support MySQL 8.x.
14+
15+
### BREAKING CHANGES:
16+
17+
Changes related to `replication_group_member_stats` collector:
18+
* metric "transaction_in_queue" was Counter instead of Gauge
19+
* renamed 3 metrics starting with `mysql_perf_schema_transaction_` to start with `mysql_perf_schema_transactions_` to be consistent with column names
20+
* exposing only server's own stats by matching MEMBER_ID with @@server_uuid resulting "member_id" label to be dropped.
1321

1422
## 0.12.1 / 2019-07-10
1523

collector/perf_schema_replication_group_member_stats.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -37,25 +37,25 @@ var (
3737
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_in_queue"),
3838
"The number of transactions in the queue pending conflict detection checks.", nil, nil)},
3939
"COUNT_TRANSACTIONS_CHECKED": {prometheus.CounterValue,
40-
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_checked"),
40+
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_checked_total"),
4141
"The number of transactions that have been checked for conflicts.", nil, nil)},
4242
"COUNT_CONFLICTS_DETECTED": {prometheus.CounterValue,
43-
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "conflicts_detected"),
43+
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "conflicts_detected_total"),
4444
"The number of transactions that have not passed the conflict detection check.", nil, nil)},
4545
"COUNT_TRANSACTIONS_ROWS_VALIDATING": {prometheus.CounterValue,
46-
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_rows_validating"),
46+
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_rows_validating_total"),
4747
"Number of transaction rows which can be used for certification, but have not been garbage collected.", nil, nil)},
4848
"COUNT_TRANSACTIONS_REMOTE_IN_APPLIER_QUEUE": {prometheus.GaugeValue,
4949
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_remote_in_applier_queue"),
5050
"The number of transactions that this member has received from the replication group which are waiting to be applied.", nil, nil)},
5151
"COUNT_TRANSACTIONS_REMOTE_APPLIED": {prometheus.CounterValue,
52-
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_remote_applied"),
52+
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_remote_applied_total"),
5353
"Number of transactions this member has received from the group and applied.", nil, nil)},
5454
"COUNT_TRANSACTIONS_LOCAL_PROPOSED": {prometheus.CounterValue,
55-
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_local_proposed"),
55+
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_local_proposed_total"),
5656
"Number of transactions which originated on this member and were sent to the group.", nil, nil)},
5757
"COUNT_TRANSACTIONS_LOCAL_ROLLBACK": {prometheus.CounterValue,
58-
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_local_rollback"),
58+
prometheus.NewDesc(prometheus.BuildFQName(namespace, performanceSchema, "transactions_local_rollback_total"),
5959
"Number of transactions which originated on this member and were rolled back by the group.", nil, nil)},
6060
}
6161
)

0 commit comments

Comments
 (0)