Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2 client_secret should be optional #528

Closed
TheSpiritXIII opened this issue Oct 27, 2023 · 0 comments · Fixed by #547
Closed

OAuth 2 client_secret should be optional #528

TheSpiritXIII opened this issue Oct 27, 2023 · 0 comments · Fixed by #547

Comments

@TheSpiritXIII
Copy link
Contributor

After #294, client_secret was made to be required.

According to the OAuth 2.0 spec (https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1), it is optional:

The client MAY omit the parameter if the client secret is an empty string.

You can see this with OAuth 2.0 providers points out it's optional, e.g. Microsoft.

We even show it as optional in the configuration documentation but this is not what our behavior actually is.

While it is best practice to include it in production environments, we should let users decide. Alternatively, let's be consistent and clear in our documentation if we diverge from expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant