-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Desc fields #322
Comments
@beorn7 What do you think? |
The way Desc work will change fundamentally with #222. Tests in code using client_golang (in contrast to tests that test client_golang itself) must not depend in implementation details of client_golang. Simply making internal fields exported in Desc would only allow users to depend on all those internal implementation details (that are about to change anyway). I would like to ask you to wait for the outcome of #58 and then #230. Right now, exposing Desc fields would be a step in the wrong direction. |
How can I help you to make a step in the right direction then? I just hit this issue again and would like to remove that hack. |
The required change will go along with a lot of breaking changes and is therefore scheduled for v0.10, see milestones. |
I would like to have read-only access to
Desc
fields, specifically,fqName
. Right now we use an ugly hack in tests to get it. Methods forhelp
,constLabelPairs
andvariableLabels
can also be provided for convenience.I can send a PR if you are ok with that.
Related to #222.
The text was updated successfully, but these errors were encountered: