Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Desc fields #322

Closed
AlekSi opened this issue Jul 7, 2017 · 4 comments
Closed

Expose Desc fields #322

AlekSi opened this issue Jul 7, 2017 · 4 comments

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Jul 7, 2017

I would like to have read-only access to Desc fields, specifically, fqName. Right now we use an ugly hack in tests to get it. Methods for help, constLabelPairs and variableLabels can also be provided for convenience.

I can send a PR if you are ok with that.

Related to #222.

@AlekSi
Copy link
Contributor Author

AlekSi commented Jul 7, 2017

@beorn7 What do you think?

@beorn7
Copy link
Member

beorn7 commented Jul 7, 2017

The way Desc work will change fundamentally with #222. Tests in code using client_golang (in contrast to tests that test client_golang itself) must not depend in implementation details of client_golang. Simply making internal fields exported in Desc would only allow users to depend on all those internal implementation details (that are about to change anyway).

I would like to ask you to wait for the outcome of #58 and then #230. Right now, exposing Desc fields would be a step in the wrong direction.

@beorn7 beorn7 closed this as completed Jul 7, 2017
@AlekSi
Copy link
Contributor Author

AlekSi commented Aug 29, 2017

Right now, exposing Desc fields would be a step in the wrong direction.

How can I help you to make a step in the right direction then? I just hit this issue again and would like to remove that hack.

@beorn7
Copy link
Member

beorn7 commented Aug 29, 2017

The required change will go along with a lot of breaking changes and is therefore scheduled for v0.10, see milestones.
The plan is to first get v0.9 out of the door so that we have all the low hanging fruit we can get without breaking changes.
You could check out if you can help with any of the 11 remaining v0.9 issues. But most of them require a lot of context. Unless you are a domain expert already in one, it will probably require more time to transfer context to you and review the code than doing it myself.
(And yes, I'm planning to work on this soon.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants