Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust examples after refactor #876

Closed
paulfantom opened this issue Jan 15, 2021 · 2 comments · Fixed by #960
Closed

Adjust examples after refactor #876

paulfantom opened this issue Jan 15, 2021 · 2 comments · Fixed by #960
Assignees
@paulfantom
Labels
kind/bug

Comments

@paulfantom
Copy link
Member

All *.jsonnet files in examples/ need adjusting after refactoring from #566
@paulfantom paulfantom self-assigned this Jan 15, 2021
This was referenced Feb 2, 2021
Merged
Merged
@brancz
Copy link
Collaborator

brancz commented Feb 18, 2021

Anything left to be done here?

@paulfantom
Copy link
Member Author

Yes, one thing is left:

  • example for adding custom alerts/rules should be changed to point people to create new PrometheusRule object

Sorry for not specifying it earlier.

@paulfantom paulfantom mentioned this issue Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulfantom paulfantom

Labels
kind/bug
Projects
None yet
Milestone
No milestone
2 participants
@paulfantom @brancz