-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per Probe/Packet Timeout Option #19
Comments
Yup! Absolutely something we want to implement. |
Hi! I'm interesting in either implementing this or rebasing https://github.com/go-ping/ping/pull/202/files into pro-bing. Which way would you guys prefer? |
It would need to fix the implementation issues of the original PR. As pointed out in several PRs to do per-packet timeouts, it needs to use a Go timer callback to accurately handle the timeouts, as well as not constantly sweep the packet tracking data. I started working on refactoring the packet tracking in #9. The intention was to make it easier to implement the per-packet timeouts. |
I'll take a look at #9 and go-ping/ping#202 I think using a Go timer makes sense, though I'm not sure how expensive it is. I'll take a look at the implementation to make sure its cheap. |
|
On go-ping this PR existed:
go-ping/ping#202
It would be very usefull to have a packet timeout option on the Pinger in this package
The text was updated successfully, but these errors were encountered: