Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring is off? #237

Closed
Lambdaphile opened this issue Mar 11, 2023 · 6 comments
Closed

Coloring is off? #237

Lambdaphile opened this issue Mar 11, 2023 · 6 comments
Assignees
Labels
assigned Under progress.

Comments

@Lambdaphile
Copy link

Hi, sorry for the vague title, wasn't sure how to name this issue.

I use the same theme in VSCode, and the color pallet is much richer there. That's what I mean:
Screen Shot 2023-03-11 at 15 50 15 (2)

VS the github-nvim-theme in Neovim v.0.8.3+
Screen Shot 2023-03-11 at 15 50 53 (2)

At first, I thought that this was a Neovim issues, but then I checked other themes like tokyonight and they're ok:
Screen Shot 2023-03-11 at 15 58 13 (2)

Is this a known thing, done on purpose, will it get fixed in the upcoming rewrite?

@ful1e5
Copy link
Member

ful1e5 commented Mar 12, 2023

Is this a known thing, done on purpose, will it get fixed in the upcoming rewrite?

Yes.

@sethawright
Copy link

For now, make sure you are using tag 0.0.7 in your plugin manager.

 -- lazy.nvim
  {
    "projekt0n/github-nvim-theme",
    tag = "v0.0.7",
    config = function()
      require("github-theme").setup({})
      vim.cmd("colorscheme github_dark")
    end,
  },

@tmillr
Copy link
Member

tmillr commented Apr 25, 2023

I'm having the same issue. In a js file, parenthesis are blue, but they're supposed to be the foreground color (or similar in color to the global foreground color). Im using the dimmed variant.

Edit: same deal with variables (@variable or @variable.javascript highlight group)

@ful1e5
Copy link
Member

ful1e5 commented May 3, 2023

Try a new revision on main after 4d5a4ce.
Refactoring is almost done; only docs and new features are left. Report any theme highlight issues here or on #226. I want to merge them upstream before release.

@ful1e5 ful1e5 pinned this issue May 6, 2023
@ful1e5 ful1e5 self-assigned this May 7, 2023
@ful1e5 ful1e5 added the assigned Under progress. label May 7, 2023
@ful1e5 ful1e5 unpinned this issue May 22, 2023
@tmillr
Copy link
Member

tmillr commented Jun 18, 2023

@Lambdaphile Try updating the plugin. Alot of highlighting changes just landed on the main branch.

@ful1e5
Copy link
Member

ful1e5 commented Jul 15, 2023

Closing due to inactivity. Can reopen later.

@ful1e5 ful1e5 closed this as completed Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress.
Projects
None yet
Development

No branches or pull requests

4 participants