Refactor package rule generation

Move default configuration that's shared between all rules into a
function instead of repeating the raw dict for each rule.

Note that this reorders the rule contents in the generated JSON since by
default Python dict serialization is done by insertion order.

Author: simu

hooks/post_gen_project.py

@@ -74,24 +74,28 @@
 # We always add an empty package rules list
 renovatejson["packageRules"] = []
 
-if automerge_patch:
-    # automerge patch PRs
-    patch_rule = {
-        "matchUpdateTypes": ["patch"],
-        # negative match: do not match versions that match regex `^v?0\.`
-        "matchCurrentVersion": "!/^v?0\\./",
+
+def rule_defaults(updateTypes, extraLabels=[]):
+    return {
+        "matchUpdateTypes": updateTypes,
         "automerge": True,
         # NOTE: We can't use Platform Automerge because the repositories are configured manually,
         # so we can't be sure the "require status checks" option is always enabled, and without
         # that, platformAutomerge does not wait for tests to pass.
         "platformAutomerge": False,
         # NOTE: We need to add all the labels we want here, renovate doesn't inherit globally
         # specified labels for package rules
-        "labels": ["dependency", "automerge"],
+        "labels": ["dependency", "automerge"] + extraLabels,
     }
-    if automerge_patch_v0:
-        # remove match current version if we want v0.x patch automerge
-        del patch_rule["matchCurrentVersion"]
+
+
+if automerge_patch:
+    # automerge patch PRs
+    patch_rule = rule_defaults(["patch"])
+    if not automerge_patch_v0:
+        # If automerging patch updates for v0.x dependencies isn't enabled, do not match versions
+        # that match regex `^v?0\.`
+        patch_rule["matchCurrentVersion"] = "!/^v?0\\./"
 
     # Set excludePackagePatterns to the provided list of package patterns for which patch PRs
     # shouldn't be automerged. Only set the field if the provided list isn't empty.
@@ -112,20 +116,12 @@
 # be automerged in cookiecutter argument `automerge_patch_regexp_blocklist`.
 if not automerge_patch_v0 and len(automerge_patch_v0_regexp_allowlist) > 0:
     patterns = automerge_patch_v0_regexp_allowlist.split(";")
-    patch_v0_rule = {
-        "matchUpdateTypes": ["patch"],
-        # only apply for packages whose current version matches `v?0\.`
-        "matchCurrentVersion": "/^v?0\\./",
-        "automerge": True,
-        # NOTE: We can't use Platform Automerge because the repositories are configured manually,
-        # so we can't be sure the "require status checks" option is always enabled, and without
-        # that, platformAutomerge does not wait for tests to pass.
-        "platformAutomerge": False,
-        # NOTE: We need to add all the labels we want here, renovate doesn't inherit globally
-        # specified labels for package rules
-        "labels": ["dependency", "automerge"],
-        "matchPackagePatterns": patterns,
-    }
+
+    patch_v0_rule = rule_defaults(["patch"])
+    # only apply for packages whose current version matches `v?0\.`
+    patch_v0_rule["matchCurrentVersion"] = "/^v?0\\./"
+    patch_v0_rule["matchPackagePatterns"] = patterns
+
     renovatejson["packageRules"].append(patch_v0_rule)
 
 # NOTE: Later rules in `packageRules` take precedence