Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Stabilizing the Cell Space #2519

Open
13 of 21 tasks
EwoutH opened this issue Nov 25, 2024 · 10 comments
Open
13 of 21 tasks

Tracking issue: Stabilizing the Cell Space #2519

EwoutH opened this issue Nov 25, 2024 · 10 comments

Comments

@EwoutH
Copy link
Member

EwoutH commented Nov 25, 2024

A tracking issue for stabilizing the experimental Cell Space.

Mesa 3.0

A lot of active development, including:

Current spaces

Mesa 3.1

Integration and documentation.

Mesa 3.2

Stabilizing release

Current spaces

Mesa 4.0

  • Make new (optionally breaking) changes to Cell Space
  • Remove current spaces
  • Rename to "space"?

Everyone let me know what you think, especially @quaquel and @Corvince.

@Souvik9205
Copy link

Hi, I would like to work on this issue

@EwoutH
Copy link
Member Author

EwoutH commented Dec 8, 2024

Great! You can see what’s still TODO, feel free to pick one and start working on it.

@quaquel
Copy link
Member

quaquel commented Dec 12, 2024

@EwoutH, do we want to move over the basic examples as part of 3.2, or as part of 3.3?

Personally, I think it would make more sense to do it for 3.2.

@EwoutH
Copy link
Member Author

EwoutH commented Dec 12, 2024

I’m also good with 3.2, like the tracking issue currently states.

The big ticket item is integrating the Continuous Space, so we can keep a unified concept of space.

@quaquel
Copy link
Member

quaquel commented Dec 12, 2024

The big ticket item is integrating the Continuous Space, so we can keep a unified concept of space.

sounds like a fun thing for me to work on over the christmas break. In the mean time, I'll continue updating various examples to use all the new stuff that came in 3.1.

@EwoutH
Copy link
Member Author

EwoutH commented Dec 12, 2024

Actually, I might be interested to do some exploratory work on this over the weekend, as an integrated effort on integrating (parts of) Mesa-Geo.

We can do the MPIEvaluator combo, were I do some pathfinding and deliver a shit PoC and you make it a proper implementation ;)

@EwoutH
Copy link
Member Author

EwoutH commented Jan 7, 2025

Now that we want to stabilize the the cell space, we have to think about the namespace or module name we're going to put it in.

Since it also contains a continuous component, I don't think cell_space is the perfect description anymore. We could simply put it in a space namespace (folder) and let the space module exists as is. That could introduce naming conflicts, so we could also name it new_space before 4.0, and than with 4.0 make it simply space again.

@quaquel
Copy link
Member

quaquel commented Jan 8, 2025

Since it also contains a continuous component,

Cell-spaces/discrete spaces and continuous spaces are really different things, so I would counsel against collapsing them. Conceptually, the underlying maths, for example, is quite distinct. Implementation-wise and API-wise, they are also quite different. I want to explore the possibility of having a generic space protocol to improve API alignment, but I don't see a feasible or desirable path beyond that.

So, I prefer mesa.discrete_space and mesa.continuous_space as folders while we leave the existing mesa.space file with a deprecation warning. I prefer folders over a single file because of the ease of finding stuff. From a user side, it does not matter as long as the relevant stuff is just importable from the right namespace.

@EwoutH
Copy link
Member Author

EwoutH commented Jan 8, 2025

Sounds logical. Maybe we can even do mesa.space.discrete and .continuous.

@quaquel
Copy link
Member

quaquel commented Jan 8, 2025

not sure: flat is better than nested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants