-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolaraViz: visualization should update on parameter changes #2239
Comments
Sounds like a bug. It is supposed to be reactive to those changes. |
I wasn't sure if it was working as intended or not ;) But looking at the code now I see that some care is taken to split off fixed vs dynamic variables so this is a bug indeed. I will edit the issue to reflect that. |
Can't reproduce this one. Pressing reset does indeed reset the space drawn to its step 0 state, if you can confirm. |
Correct , i only meant that i expected perhaps that pressing reset might cause the drawer to redraw with the current parameters. I should perhaps delete that distractor from the issue? EDIT: I clarified what I meant about the reset button. |
Thanks for the detailed reports of those issues @DrEntropy! Do you see any place where documentation about this part of the visualization stack could be improved (docstring, example models, tutorial)? And if so, would you like to improve any one of these? |
@EwoutH There are some places (for example, demonstrating custom drawers), I will take a closer look and see if I can help. |
This is on branch main (or 3.0.0a2 (2024-08-21))
Describe the bug
Currently, using SolaraViz, manipulating the controls to change
model_params
doesn't change seem to cause a redraw for thespace_drawer
. (Changing the seed, or advancing one step does redraw with the current parameters). This is most noticeable for network space models, for examplevirus_on__network
. I also note that pressing reset redraws but not with the updated model parameters.Expected Behavior
Ideally (perhaps optionally) the model parameters should be reactive. This way the user can experiment with the network structures in real time.
To Reproduce
Use main branch mesa-examples
virus_on_network
, runsolara run app.py
, note that model steps fine, however changing parameters has no visible effect until you pressstep
or change the seed.EDIT: Clarified what happens with the 'reset' button.
The text was updated successfully, but these errors were encountered: