@Data needs noEqualsAndHashCode/equalsAndHashCode option

[lombokissues]

Migrated from Google Code (issue 98)

[lombokissues]

👤 vit6ak   🕗 Jan 17, 2010 at 13:36 UTC

Maybe you think that following code is a solution:
@ Override
public boolean equals(Object obj) {
return super.equals(obj);
}

@ Override
public int hashCode() {
    return super.hashCode();
}

However, consider these two situations:

• equals and hashCode are final
• you are subclassing a class: you get a warning about these two methods.
  You can solve it vy @ EqualsAndHashCode(callSuper=false), but you get
  another warning.

So I think that @ Data(noEqualsAndHashCode=true) or
@ Data(equalsAndHashCode=false) it the best solution.

[lombokissues]

👤 henri.tremblay   🕗 Mar 28, 2010 at 10:30 UTC

I support this idea. In fact I would also add a noToString. Something like:

public @ interface Data {
boolean addEqualsHashCode() default true;
boolean addGetters() default true;
boolean addSetters() default true;
boolean addToString() default true;
}

Another possibility is to allow Getter and Setter to target the class. Since ToString
and EqualsAndHashCode already exist, it will have the same result.

[lombokissues]

👤 reinierz   🕗 Jul 19, 2010 at 15:03 UTC

@ Getter and @ Setter are now capable of targetting the class, as of v0.9.3 which we'll release next.

[lombokissues]

👤 vit6ak   🕗 Jul 19, 2010 at 16:23 UTC

It is great. The only missing thing is IMHO extracted constructor generation which is discussed in Lombok Ggroups. I have to read the discussion in future.

[lombokissues]

👤 r.spilker   🕗 Jul 20, 2010 at 07:50 UTC

It's there. See issue #152

[lombokissues]

End of migration