Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasDefault param doesn't need to be set if default variant is found #324

Closed
Pike opened this issue Dec 7, 2018 · 1 comment
Closed

hasDefault param doesn't need to be set if default variant is found #324

Pike opened this issue Dec 7, 2018 · 1 comment
Labels
fluent-syntax

Comments

@Pike
Copy link
Contributor

Pike commented Dec 7, 2018

Found this when comparing the 0.8 branches of python and js, hasDefault = true is useless in

fluent.js/fluent-syntax/src/parser.js

Line 336 in 6edf276

hasDefault = true;

?
@stasm stasm mentioned this issue Dec 11, 2018
Merged
@stasm
Copy link
Contributor

stasm commented Dec 13, 2018

Fixed by #325 and merged into master in #303.

@stasm stasm closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fluent-syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pike @stasm