Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double encoding issue in http url #277

Closed
tarunKoyalwar opened this issue Oct 31, 2023 · 0 comments · Fixed by #278 or #275
Closed

fix double encoding issue in http url #277

tarunKoyalwar opened this issue Oct 31, 2023 · 0 comments · Fixed by #278 or #275
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@tarunKoyalwar
Copy link
Member

Nuclei version:

dev only

Current Behavior:

  • looks like a recent change in utils is causing double encoding issue in nuclei dev branch
[✘] Test "protocols/http/http-paths.yaml" failed: expected: [/1337?with=param /some%0A/%0D /%73%6f%6d%65%0A/%0D /%00test%20 /text4shell/attack?search=$%7bscript:javascript:java.lang.Runtime.getRuntime().exec('nslookup%20{}.getparam')%7d /test/..;/..;/ /xyz/%25u2s/%25invalid //CFIDE/wizards/common/utils.cfc /1337?with=param /some%0A/%0D /%73%6f%6d%65%0A/%0D /%00test%20 /text4shell/attack?search=$%7bscript:javascript:java.lang.Runtime.getRuntime().exec('nslookup%20{}.getparam')%7d /test/..;/..;/ /xyz/%25u2s/%25invalid //CFIDE/wizards/common/utils.cfc]
actual  : [/1337?with=param /some%250A/%250D /%2573%256f%256d%2565%250A/%250D /%2500test%2520 /text4shell/attack?search=$%7bscript:javascript:java.lang.Runtime.getRuntime().exec('nslookup%20{}.getparam')%7d /test/..;/..;/ /xyz/%25u2s/%25invalid //CFIDE/wizards/common/utils.cfc /1337?with=param /some%250A/%250D /%2573%256f%256d%2565%250A/%250D /%2500test%2520 /text4shell/attack?search=$%7bscript:javascript:java.lang.Runtime.getRuntime().exec('nslookup%20{}.getparam')%7d /test/..;/..;/ /xyz/%25u2s/%25invalid //CFIDE/wizards/common/utils.cfc]

https://github.com/projectdiscovery/nuclei/actions/runs/6695871590/job/18193099384

Expected Behavior:

  • no double encoding

Steps To Reproduce:

Anything else:

@tarunKoyalwar tarunKoyalwar added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 31, 2023
@tarunKoyalwar tarunKoyalwar self-assigned this Oct 31, 2023
@tarunKoyalwar tarunKoyalwar transferred this issue from projectdiscovery/nuclei Oct 31, 2023
@tarunKoyalwar tarunKoyalwar linked a pull request Oct 31, 2023 that will close this issue
@tarunKoyalwar tarunKoyalwar added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Oct 31, 2023
@tarunKoyalwar tarunKoyalwar linked a pull request Oct 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
1 participant