-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to set multiple set-cookie headers #5855
Comments
Hey @dnbn! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
The Contour project currently lacks enough contributors to adequately respond to all Issues. This bot triages Issues according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
Hello, please keep this issue as fresh. I'm still interested. |
The Contour project currently lacks enough contributors to adequately respond to all Issues. This bot triages Issues according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
The Contour project currently lacks enough contributors to adequately respond to all Issues. This bot triages Issues according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
What steps did you take and what happened:
RFC actually allows the server to send multiples "set-cookie" header if they don't have the same name. Unfortunately contour overwrite the header and only keep the last one.
From this code, it seems there are cases where envoy can already make an append instead of a set. See here.
What did you expect to happen:
When multiple set-cookie headers are set in the same httpproxy, all should be kept and appended to the header list.
Anything else you would like to add:
Another approach could be to add the ability of "append header" instead of "set" header. This has already been suggested here
Environment:
Thanks in advance
The text was updated successfully, but these errors were encountered: