Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow wildcards on certificate generation #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow wildcards on certificate generation #524

wants to merge 1 commit into from

Conversation

ppodevlabs
Copy link

Fix #523

@ppodevlabs
fix: allow wildcards on certificate generation
bf43c7b 
Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
@prometherion
Copy link
Member

As I commented in the issue linked to this PR, I think this doesn't work: wildcard domains require the DNS01 challenge.

May I ask you if you smoke-tested this change in your cluster?

@prometherion
Copy link
Member

Smoke test here, LGTM to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

@oliverbaehler oliverbaehler oliverbaehler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm chart (cert-manager) does not support wildcards
3 participants
@ppodevlabs @prometherion @oliverbaehler