Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Audit bluemagic.lua params. #354

Open
mrhappyasthma opened this issue Feb 19, 2020 · 7 comments
Open

Audit bluemagic.lua params. #354

mrhappyasthma opened this issue Feb 19, 2020 · 7 comments
Labels
bug Something isn't working focus Related to a current project focus

Comments

@mrhappyasthma
Copy link
Contributor

Theres a Lua table called params passed to a few functions in bluemagic.lua, however a few of the parameters are unused.

We should either:

  • Remove them
    • If so, they could always be added back later when properly implemented.
  • Update the code to properly reference them
    • If so, audit all spells to make sure they set the proper values, now that it's used.
@mrhappyasthma
Copy link
Contributor Author

params.tpmod and the TPMOD_* enum-like values are unused, but set in most tests.

@mrhappyasthma
Copy link
Contributor Author

params.azuretp is unused, but set in most tests.

@mrhappyasthma
Copy link
Contributor Author

params.dmgtype is used but undocumented and not used uniformly.

@mrhappyasthma
Copy link
Contributor Author

params.tMultiplier is set in many tests (although not all). It's used in code but not documented in the comment on the method where it's used.

@mrhappyasthma
Copy link
Contributor Author

params.offcratiomod is not documented, but is used in cannonball.lua.

@SirGouki
Copy link
Contributor

The latter choice should be done instead of the former. They are likely in there in preparation for finishing the spells, so removing them doesn't make sense.

@ibm2431
Copy link
Contributor

ibm2431 commented Feb 19, 2020

Related: #351

@ibm2431 ibm2431 added the bug Something isn't working label Feb 19, 2020
@zircon-tpl zircon-tpl added the focus Related to a current project focus label Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working focus Related to a current project focus
Projects
None yet
Development

No branches or pull requests

4 participants