-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic swaps from SOL to SRM/RAY/OXY not working as swap button grays on hover #63
Comments
Hi just double checked it. Im Sure its disabled. IMHO graying on hover as a UX feature is a bit confusing, but definitely not doing anything and not swapping. specifically: no confirmation (or anything) and balances remain unchanged. Specifically Im trying to swap 0.1 SOL for SRM/RAY etc just to prove it works. I only have one SOL in the wallet (more to come once ive proved its safe and swaps are working ok....). Could the account balance and swap amounts be too small? Im happy to help test this and can provide any diagnostic data you need. Thanks |
Hi do you have any more feedback common access via sollet.io so should be a reproducible issue. Generally is this the best channel for user-land support? Do you have a better support channel than github that is not discord. Email support would be more structured. I have been using Atomic Wallet recently and the email support is first class and certainly a good model to work for any organisation supporting a wallet. |
Github is best for developer issues and Discord is best for more interactive support non-development issues. |
Thanks. This looks like a pretty fundamental issue and I cant see I am doing anything wrong. Whats the best way to continue testing this particular issue? Basic SPL swaps not working... Can you confirm the same issue? |
I cannot reproduce the issue described. The only thing I can think of is that you either don't have the spl token accounts created or your balances are zero. |
I sent a screenshot showing non-zero balance for sol. Please can you advise further what you mean by SPL token accounts. Do I need to do something other than add new tokens? Do I need to create new accounts for each token I add? Thanks |
Please share your browser console logs. Right click. Inspect. A tab bar should popup. Click console and share the screenshot. |
Clicking swap on sollet.io (MAINNET BETA) did raise an error:
It only does this on the first click until close and re-open the Swap dialog and reclick |
The ultimate problem is that you don't have a bunch of pre-requisite accounts setup. Specifically,
The work around for this would be for you to swap on the individual markets listed in the To properly solve this, the swapper should provide explicit flows for these cases, similar to #62. The alternative would be to batch transactions--since, in this case, the transaction is broken up into several to work around the tx size limit--but rpc nodes aren't reliable enough to support that at the moment, so explicit flows are the better choice. |
This advice is quite low level and confusing offering a lot of undocumented(?) advice. The error message states the need to complete a single transaction but you are also advising the need to perform a complex series of prerequisite actions just to swap SOL for SRM (or any SPL token). Im also confused by advice to obtain USDC? What is this for? Why is there a USDC intermediary between SOL and SPL tokens? This doesnt sound correct. If it is correct is this documented? If what you say regarding pre-requisite accounts and USDC is correct the basic sollet.io wallet swap function is too complex for users who just want to hold SOL and SPL tokens in a wallet. This is the most complex swap I've encountered in crypto-land and less intutive than direct market trading on a CEX. Also the UI does not advise on correct method and just silently fails without issuing error. I hope you can consider this as constructive feedback I really want to use sollet.io so I am happy to assist to make swapping easier. |
Can you confirm that I have set up the correct accounts from the screenshot? Do I need to create additional entities other than those shown? OR perhaps in another screen? As you can see I have only a single account with multiple (token) balances. Is the prerequisite set of accounts you refer to? If this is incorrect is there any documentation advising on how way to swap through sollet.io and USDC? The prerequisites you describe sound too complex too perform a simple swap from SOL to SRM. Do I really need:
to swap SOL to SRM/RAY/XY etc through the wallet? I think other instructions may be too low level and complex for an average user wanting to use this wallet. The error I received was: SOL must be swapped in a single transaction. The work around for this would be for you to swap on the individual markets listed in the info dialog's trade route. Once you've done that you can swap. To properly solve this, the swapper should provide explicit flows for these cases, similar to #62. The alternative would be to batch transactions--since, in this case, the transaction is broken up into several to work around the tx size limit--but rpc nodes aren't reliable enough to support that at the moment, so explicit flows are the better choice. I dont undertstand any of these instructions and it sounds quite low level for a sollet.io user to understand. A simple swap has a standard interface in most wallets, CEX and DEX and doesnt require any additional prerequisite other than a source token fund to initiate the swap. I appreciate your time and attention in trying to assist. If this issue is not resolvable here please can you refer to the correct instructions for completing a straight SOL->SRM swap. |
Please let me know if need further information or diagnostics. I am very happy to assist to help improve the UX flow for these swaps. |
Are you able to duplicate this issue and is it expected at this stage of development. i.e. Is a simple Swap from SOL to SPL (e.g. SRM) token still a WIP and dependent upon USDC? Can you further clarify the role of USDC and the prerequisite account requirements as this has left me somewhat confused over the SOL/SPL swap process in general? I hope to be able use sollet.io regularly in the future and I would like to avoid making inappropriate posts to the wrong place to discuss issues if they arise. To ease further communication please can you advise if you consider this a developer issue, a misuse of the wallet, a lack of understanding the solliet.io interface, a lack of documentation, or possibly a combination of factors? I was expecting a 1-2 click swap process and Im not sure if sollet.io is meant to work like that, or if I am doing something incorrectly? Im certainly confused by reference to USDC and Im sure other users may feel the same. I am still unclear as to what to expect in terms of a user experience to swap SOL to SPL. A simple online guide as to how its meant to work would be most helpful. |
It's not a bug. But it's a bad user experience. This is being addressed in #64. USDC comes from the fact that you were performing a transitive swap that trades across two markets. The UI only routes trades via USD(x) markets since they have the best liquidity. See the "info" popup. |
I have read: "USDC is an ERC-20 token issued on the Ethereum blockchain and can be stored in any Ethereum wallet" so Im unsure why sollet.io is performing what is essentially a native swap (SOL->SPL token) via an ethereum token. Am I understanding this correctly? I am investigating SOLANA as an alternative to the Ethereum network and I dont really understand why native swaps are taking place on the ethereum network. My main concern with this is charged Ethereum/ERC20 fees and experiencing all of the performance bottlenecks currently experienced on the etherium blockchain. |
USDC is on both ethereum and solana natively. So from the swap program's perspective, it's just another SPL token. |
Great this useful to know. So is the swap is occuring entirely on the Solana network without incurring Ethereum charges? Given the UI in its current form please can you provide some simple steps to perform a swap from SOL (native) to SRM (native) so that my balance shows SRM deposited into my account. Do I need USDC to perform the swap? If not whats the best way to proceed? Thanks |
Perhaps this issue should have started and ended with "how do i swap SOL for SRM in sollet.io?" |
That should create all the requisite accounts. |
ok i tried again and it worked fine. It would be great to miss out the USDC step if possible. I dont know how much the swaps cost. Can i see that anywhere in the sollet.io wallet? thanks |
Original issue.
I am testing this wallet for the first time with a small deposit of SOL trying to convert to other SOL tokens.
I have created balances for SRM, RAY and OXY and the basic swap function is not working.
If i select swap SOL to any of SRM/RAY/OXY the Swap button is enablled but it grays and disables when i hover it as shown in the screenshot. There are no other errors shown on the screen.
The text was updated successfully, but these errors were encountered: