The operator deployment should use non-overlapping label selector

[astefanutti]

The operator deployment is configured with the default label selector, as generated by the kubebuilder scaffolding, i.e.:

spec:
  selector:
    matchLabels:
      control-plane: controller-manager

This selector can intersect with other deployments, for instance the Open Data Hub operator, which leads to issues where selection based on this selector returns more than expected, e.g., in the OpenShift Web console:

This should be changed, so it's disjunct from any other deployments, ideally following Kubernetes recommended labels:

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

The main challenge is that deployment label selector is immutable once created, which will break the rollout deployment performed during the next OLM upgrade:

https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates

With some more background in kubernetes/kubernetes#50808.

As the project is in its early phase, the simplest approach would be to document in the release note manual deletion of the previous deployment is required.