chore: updates from PR comments

Author: ammmze

agent/src/util/config_action.rs

@@ -154,9 +154,7 @@ async fn handle_config(
         }
         // If a config is updated, delete all associated instances and device plugins and then recreate them to reflect updated config
         WatchEvent::Modified(config) => {
-            let do_recreate = should_recreate_config(&config, config_map.clone())
-                .await
-                .unwrap();
+            let do_recreate = should_recreate_config(&config, config_map.clone()).await?;
             if !do_recreate {
                 trace!(
                     "handle_config - config {:?} has not changed. ignoring config modified event.",
@@ -294,13 +292,20 @@ async fn handle_config_delete(
 /// Checks to see if the configuration needs to be recreated.
 /// At present, this just checks to see if the `.metadata.generation` has changed.
 /// The `.metadata.generation` value is incremented for all changes, except for changes to `.metadata` or `.status`.
-async fn should_recreate_config(config: &Configuration, config_map: ConfigMap) -> Result<bool, ()> {
+async fn should_recreate_config(
+    config: &Configuration,
+    config_map: ConfigMap,
+) -> Result<bool, anyhow::Error> {
     let name = config.metadata.name.clone().unwrap();
-    let last_generation = config_map.lock().await.get(&name).unwrap().last_generation;
-    trace!(
-        "should_recreate_config - checking if config {} needs to be recreated",
-        name,
-    );
+    let last_generation = config_map
+        .lock()
+        .await
+        .get(&name)
+        .ok_or(anyhow::anyhow!(
+            "Configuration {} not found in ConfigMap",
+            name
+        ))?
+        .last_generation;
 
     if config.metadata.generation == last_generation {
         return Ok(false);