Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to use a Uint32Array instead of a Uint32Array in src/webgl/p5.RendererGL.Retained.js comment #5832

Closed
1 of 17 tasks
SableRaf opened this issue Oct 14, 2022 · 1 comment · Fixed by #5833
Closed
1 of 17 tasks

Comments

@SableRaf
Copy link
Contributor

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)

p5.js version

n/a

Web browser and version

n/a

Operating System

n/a

Steps to reproduce this

In src/webgl/p5.RendererGL.Retained.js starting at line 79 you find the following comment

// If any face references a vertex with an index greater than the maximum
// un-singed 16 bit integer, then we need to use a Uint32Array instead of a
// Uint32Array
const hasVertexIndicesOverMaxUInt16 = vals.some(v => v > 65535);
let type = hasVertexIndicesOverMaxUInt16 ? Uint32Array : Uint16Array;

The last part repeats Uint32Array twice.

It should say then we need to use a Uint32Array instead of a Uint16Array

@SableRaf SableRaf added the Bug label Oct 14, 2022
@welcome
Copy link

welcome bot commented Oct 14, 2022

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant