Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createColorPicker() from p5.dom is Missing from Reference #3422

Closed
2 of 14 tasks
duskvirkus opened this issue Dec 24, 2018 · 5 comments
Closed
2 of 14 tasks

createColorPicker() from p5.dom is Missing from Reference #3422

duskvirkus opened this issue Dec 24, 2018 · 5 comments

Comments

@duskvirkus
Copy link
Contributor

Nature of issue?

  • Found a bug
  • Existing feature enhancement
  • New feature request

Most appropriate sub-area of p5.js?

  • Color
  • Core/Environment/Rendering
  • Data
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Other (specify if possible)
    part of p5.dom

Details about the bug:

createColorPicker() is missing from reference. I saw that @TanviKumar worked on this feature during GSOC and I saw a screen shot of their reference here. When I navigated to that url seen in the screenshot there's nothing there. I looked in the p5.dom reference but it wasn't in there. I then did a search of the site for 'createColorPicker' which only showed a web editor sketch. I was able to recreate the example using p5 and p5.dom 0.7.2 in the web editor. So createColorPicker() should be in the current reference unless I'm mistaken.

  • p5.js version: 0.7.2

Related Links:
Original color picker issue.
Pull Request for createColorPicker().
Forum discussion about a color picker which sparked this issue.

@Ajayneethikannan
Copy link
Contributor

@limzykenneth Could this issue be also caused due to the same problem as in #3444 ?
The last time data.json file was updated, was in this commit,
processing/p5.js-website@4425d5d (May 2018)
and the createColorPicker was added afterwards through this commit
ef00da5 (July 2018)

@limzykenneth
Copy link
Member

Probably yes, the reference is stuck on 0.6.1 version of p5.js

@Ajayneethikannan
Copy link
Contributor

After the updation of the reference , the createColorPicker examples can be seen in the website , but the p5 and p5-dom versions are presently in v0.5.4 (October 20, 2016), so the example is throwing reference error currently. Should I make a pull request by updating the two files (p5.min.js and p5-dom.min.js) or should this be handled in a different way ? Help please @limzykenneth !

@limzykenneth
Copy link
Member

I'm not sure I understand what you mean. The version of p5.js and p5.dom.js on the website are both 0.7.3 at the moment. createColorPicker's example is also working, just the layout needs to be tweaked.

@Ajayneethikannan
Copy link
Contributor

Oh , I am really sorry ! I must have made a mistake while checking. Sorry for disturbing you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants