Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error message when loading files that are too big #2981

Closed
2 of 14 tasks
kjhollen opened this issue Jun 7, 2018 · 5 comments · Fixed by #3127
Closed
2 of 14 tasks

show error message when loading files that are too big #2981

kjhollen opened this issue Jun 7, 2018 · 5 comments · Fixed by #3127
Assignees
Labels

Comments

@kjhollen
Copy link
Member

kjhollen commented Jun 7, 2018

Nature of issue?

  • Found a bug
  • Existing feature enhancement
  • New feature request

Most appropriate sub-area of p5.js?

  • Color
  • Core/Environment/Rendering
  • Data
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Other (specify if possible)

Feature enhancement details:

There are currently two open issues for when the browser fails to load a file because it is too big: #2661 for loadStrings() and #2216 for loadTable(). I think they are not possible to fix, but it would be good to produce an error message for the user and suggest breaking the data into smaller files as a work around.

New feature details:

@TanviKumar
Copy link
Member

Taking this up as part of GSoC

@TanviKumar TanviKumar self-assigned this Jun 11, 2018
@lmccart
Copy link
Member

lmccart commented Jul 19, 2018

hi @TanviKumar what's the status on this one?

@TanviKumar
Copy link
Member

TanviKumar commented Jul 19, 2018 via email

@TanviKumar
Copy link
Member

Hi @kjhollen, in order to limit the user from the loading very large files (in this case anything greater than 64MB in size), I plan on using the HEAD request to obtain the content length of the file without fetching the entire body. Would it be wise to use synchronous XHR or Async XHR? Here's a link to what I've been referring to.

@limzykenneth
Copy link
Member

I think async will be better just so that if the server somehow has long latency it will not block the whole js thread causing the user's sketch to stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants